feat: update apiVersion for PodDisruptionBudget and HorizontalPodAutoscaler
#685
+49
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Burak Karakan <burak.karakan@gmail.com>
Signed-off-by: Burak Karakan <burak.karakan@gmail.com>
Signed-off-by: Burak Karakan <burak.karakan@gmail.com>
Signed-off-by: Burak Karakan <burak.karakan@gmail.com>
Closed
4 tasks
thesuperzapper
requested changes
Feb 7, 2023
There was a problem hiding this comment.
@karakanb thanks for the PR, I agree that this is an important change, are you able to make the small number of changes (listed in the comments) so we can get this released ASAP?
thesuperzapper
changed the title
PodDisruptionBudget and HorizontalPodAutoscaler (fix 1.25+)
Signed-off-by: Burak Karakan <burak.karakan@gmail.com>
Signed-off-by: Burak Karakan <burak.karakan@gmail.com>
…a versions Signed-off-by: Burak Karakan <burak.karakan@gmail.com>
|
@thesuperzapper I have done the changes you have asked for, hope it's good to go now. 🤞 |
|
+1 Any news? |
|
Hey guys, Any news on this? PodDisruptionBudget has been in known deprecation since 1.21. This is now blocking many peoples cluster upgrades. @thesuperzapper is there anything we as the community can do to move this along faster? |
thesuperzapper
changed the title
PodDisruptionBudget and HorizontalPodAutoscaler (fix 1.25+)PodDisruptionBudget and HorizontalPodAutoscaler apis (fix 1.25+)
4 tasks
thesuperzapper
changed the title
PodDisruptionBudget and HorizontalPodAutoscaler apis (fix 1.25+)PodDisruptionBudget and HorizontalPodAutoscaler apis (fix 1.25+)
thesuperzapper
changed the title
PodDisruptionBudget and HorizontalPodAutoscaler apis (fix 1.25+)PodDisruptionBudget and HorizontalPodAutoscaler
…utoscaler` Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
thesuperzapper
added
the
status/ready-to-merge
thesuperzapper
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
@karakanb thanks for your patience, I will be including this PR in 8.7.0 of the chart today.
Note that I pushed a small doc fix to your branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
PodDisruptionBudgetandHorizontalPodAutoscaleruse unavailable apis (fix Kubernetes 1.25+) #679What does your PR do?
This PR updates the default
apiVersionswe use for thePodDisruptionBudgetandHorizontalPodAutoscalerresources to ensure support of Kubernetes 1.25+, and introduces values for users to set the older ones, if needed.Adds the following values for
PodDisruptionBudget:flower.podDisruptionBudget.apiVersion(default:policy/v1)pgbouncer.podDisruptionBudget.apiVersion(default:policy/v1)scheduler.podDisruptionBudget.apiVersion(default:policy/v1)triggerer.podDisruptionBudget.apiVersion(default:policy/v1)web.podDisruptionBudget.apiVersion(default:policy/v1)workers.podDisruptionBudget.apiVersion(default:policy/v1)Adds the following values for
HorizontalPodAutoscaler:workers.autoscaling.apiVersion(default:autoscaling/v2)Checklist
For all Pull Requests
For releasing ONLY